Conversation
mirkobrombin
approved these changes
Nov 2, 2025
Member
mirkobrombin
left a comment
mirkobrombin
left a comment
There was a problem hiding this comment.
I think APIs changed, that limit parameter was just to "take on" of them. Change looks good, now I just have to remember how this thing were (and where) packaged. 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #19
I can't speak for how this worked before, but the old method appears to continue getting the same fact.
This API endpoint appears to do the heavy lifting, reducing the need to massage the data a bit
https://catfact.ninja/#/Facts/getRandomFact
Tested locally.